Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Next.js image optimization check in app directory for Windows #6930

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

leoortizz
Copy link
Member

Description

Fixes #6868

Scenarios Tested

Sample Commands

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.79%. Comparing base (49e596e) to head (f16b5cc).
Report is 590 commits behind head on master.

Files with missing lines Patch % Lines
src/frameworks/next/utils.ts 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6930   +/-   ##
=======================================
  Coverage   54.79%   54.79%           
=======================================
  Files         359      359           
  Lines       25060    25064    +4     
  Branches     5167     5168    +1     
=======================================
+ Hits        13732    13735    +3     
  Misses      10091    10091           
- Partials     1237     1238    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leoortizz leoortizz enabled auto-merge (squash) April 4, 2024 15:20
@leoortizz leoortizz force-pushed the leoortizz_nextjsImageWindowsFix branch from 34a258b to d5db2ca Compare April 4, 2024 15:26
@leoortizz leoortizz merged commit 02e3701 into master Apr 4, 2024
35 checks passed
@leoortizz leoortizz deleted the leoortizz_nextjsImageWindowsFix branch April 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js <Image/> not working when deployed from Windows
3 participants