GitHub Action fixes for web frameworks #6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6883 +/- ##
==========================================
+ Coverage 53.82% 53.86% +0.03%
==========================================
Files 388 388
Lines 26281 26325 +44
Branches 5404 5418 +14
==========================================
+ Hits 14147 14180 +33
- Misses 10866 10875 +9
- Partials 1268 1270 +2 ☔ View full report in Codecov by Sentry. |
copy comments to writeDeployToProdActionYMLFile
jamesdaniels
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npm ci && npm run build. The reasons are:npm ci, which is required for frameworks.buildis required, but the frameworks code run the build for all frameworks, so if users does it themselves every action would build their app twice.npm ciscript automatically when using web framework.hosting.sourcedirectory whenhosting.sourceis not'.'. This is needed because"hosting"is the default directory onfirebase init hosting, so if the user follows all the default options, at the end the deployment would fail asnpm ciwould run outside the project directory.FIREBASE_CLI_EXPERIMENTS: "webframeworks"when using web frameworks.Fixes #6863, #6532 and the issues described above.
Scenarios Tested
Sample Commands