Scheduled functions use 'serviceAccount' as the invoker if provided #6858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6858 +/- ##
==========================================
+ Coverage 54.24% 54.27% +0.02%
==========================================
Files 352 352
Lines 24531 24534 +3
Branches 5079 5082 +3
==========================================
+ Hits 13307 13315 +8
+ Misses 10009 10006 -3
+ Partials 1215 1213 -2 ☔ View full report in Codecov by Sentry. |
colerogers
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6814
Previously we always used the default compute service account for the calls from Cloud Scheduler to Cloud Functions. This is unnecessary, as the user will now require actAs permissions on possibly two service accounts, and can cause errors if this default compute service account has been deleted.
Now, when serviceAccount is specified on the function, it is used both as the service account the container runs as, the valid invoker for the function, and the service account Cloud Scheduler uses to invoke the function. This slightly shifts an edge case regarding which service account the Cloud Scheduler service agent must have actAs permissions over, but that IAM concern has always existed.