Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAH bugfixes #6754

Merged
merged 2 commits into from
Feb 9, 2024
Merged

FAH bugfixes #6754

merged 2 commits into from
Feb 9, 2024

Conversation

inlined
Copy link
Member

@inlined inlined commented Feb 8, 2024

  1. Fixes issue where the --branch param on builds:create is ignored
  2. Fixes issue where the build ID uses day of week instead of day of month

@inlined inlined requested a review from bkendall February 8, 2024 00:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4abfa5) 54.31% compared to head (40a545d) 54.31%.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6754   +/-   ##
=======================================
  Coverage   54.31%   54.31%           
=======================================
  Files         349      349           
  Lines       24283    24283           
  Branches     5021     5021           
=======================================
  Hits        13190    13190           
  Misses       9888     9888           
  Partials     1205     1205

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bkendall
bkendall approved these changes Feb 9, 2024
View reviewed changes
src/commands/apphosting-builds-create.ts
@@ -16,12 +16,12 @@ export const command = new Command("apphosting:builds:create <backendId>")
const buildId =
(options.buildId as string) ||
(await apphosting.getNextRolloutId(projectId, location, backendId));
const branch = options.branch as string;
const branch = (options.branch as string | undefined) ?? "main";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A really neat improvement to this would be to see if they have a RolloutPolicy and pull the "default" branch from there. But that can come later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File a bug and assign it to me. I agree that would be much better, but IIRC rollouts is still an "internal tool" that hasn't gone through API review.

@inlined inlined merged commit 0d975e3 into master Feb 9, 2024
35 checks passed
@inlined inlined deleted the inlined.build-id-fix branch February 9, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall bkendall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inlined @codecov-commenter @bkendall