Fixes issue where Auth emulator sign in with Google only shows default tenant #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6683 +/- ##
==========================================
- Coverage 54.18% 54.18% -0.01%
==========================================
Files 347 347
Lines 24130 24132 +2
Branches 4976 4978 +2
==========================================
Hits 13075 13075
- Misses 9855 9856 +1
- Partials 1200 1201 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned here, "other tenants than the default using the Google Auth Provider are not being listed in the popup sign-in screen". This may be because the link created looks like
http://127.0.0.1:9099/emulator/auth/handler?<other_query>&tid=second. The link has a query oftidnottenantIdWe are currently looking for the
tenantIdquery.Given that we may be using
tenantIdin the past(or other sdks), keeping both instead of replacingtenantIdwithtidmight be a better optionScenarios Tested
See https://github.com/aalej/issues_5623-tid for a test case
Using the Auth emulator and Hosting emulator
Sample Commands
firebase emulators:start --project <project_id>