dynamically import Vite #6660
Merged
dynamically import Vite #6660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6660 +/- ##
=======================================
Coverage 54.15% 54.15%
=======================================
Files 347 347
Lines 24133 24133
Branches 4978 4981 +3
=======================================
Hits 13070 13070
Misses 9862 9862
Partials 1201 1201 ☔ View full report in Codecov by Sentry. |
leoortizz
commented
Jan 4, 2024
leoortizz
force-pushed
the
leoortizz_viteDynamicImport
branch
from
d4d8581 to
33b6c17
Compare
`throws: false` in async readJson doesn't work
leoortizz
requested review from
jamesdaniels
and removed request for
jamesdaniels
jamesdaniels
approved these changes
Jan 23, 2024
Member
jamesdaniels
left a comment
jamesdaniels
left a comment
There was a problem hiding this comment.
Add changelog, otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6652
Scenarios Tested
Sample Commands