Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use build target in Vite builds #6643

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Conversation

leoortizz
Copy link
Member

Description

Scenarios Tested

Sample Commands

yykamei and others added 3 commits December 19, 2023 11:30
When starting a project with `firebase init` with GitHub Workflow,
YAML files were configured with `actions/checkout@v3` previously.

Now, `actions/checkout@v4` has been released,
the template should also be updated to specify the latest version.

https://github.com/actions/checkout/releases/tag/v4.0.0

Co-authored-by: joehan <[email protected]>
* Support export in env parser

* use a noncapture group
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5f6c816) 54.18% compared to head (17c8e25) 54.18%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/frameworks/sveltekit/index.ts 50.00% 1 Missing ⚠️
src/frameworks/vite/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6643   +/-   ##
=======================================
  Coverage   54.18%   54.18%           
=======================================
  Files         347      347           
  Lines       24132    24132           
  Branches     4978     4978           
=======================================
  Hits        13075    13075           
  Misses       9856     9856           
  Partials     1201     1201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leoortizz leoortizz changed the title use build target in vite builds use build target in Vite builds Dec 26, 2023
@leoortizz leoortizz changed the base branch from next to master January 2, 2024 18:09
@leoortizz leoortizz marked this pull request as ready for review January 4, 2024 18:44
@leoortizz leoortizz enabled auto-merge (squash) January 23, 2024 13:39
@leoortizz leoortizz enabled auto-merge (squash) January 23, 2024 13:39
@leoortizz leoortizz merged commit 923edb7 into master Jan 23, 2024
35 checks passed
@leoortizz leoortizz deleted the leoortizz_vite-build-target branch January 23, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants