Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v13.0.0 Blocker] GetStorageDefaultBucket through Storage API #6467

Closed
joehan opened this issue Oct 20, 2023 · 5 comments · Fixed by #6471
Closed

[v13.0.0 Blocker] GetStorageDefaultBucket through Storage API #6467

joehan opened this issue Oct 20, 2023 · 5 comments · Fixed by #6471

Comments

@joehan
Copy link
Contributor

joehan commented Oct 20, 2023

We currently get the Default Storage Bucket by calling a FireData API that will be deprecated soon. We need to switch to using the Storage API for this. This will require some new permissions (included in Storage Bucket Viewer role) - we should also document these and ensure that when they are missing we error cleanly.

@tcf909
Copy link

tcf909 commented Dec 7, 2023

The change was rolled out before the ACL was actually made public (breaking deployments):

image

@joehan
Copy link
Contributor Author

joehan commented Dec 7, 2023

@tcf909 Just double checked the source and it seems like the permission has been in prod but is not publicly visible yet. I reached out to the responsible team to get this fixed - however, in the meantime, firebasestorage.admin and firebasestorage.viewer definitely both include "firebasestorage.defaultBucket.get" and shoudl unblock any deployment issues

@tcf909
Copy link

tcf909 commented Dec 8, 2023

@joehan thank you got the response. I will have the team add those temporarily. We had to roll back to 12.x.x latest to keep the pipeline operating today.

Any thoughts on how that permission might be "available" but not visible in our cloud console?

@joehan
Copy link
Contributor Author

joehan commented Dec 8, 2023

@tcf909 When we add new permissions, we usually make them hidden except to an allowlist list at first, which hides them from public surfaces and lets us test them out before we launch. However, these hidden permissions are still 'there' - they can still be included in publicly available roles.

In this case, the permissions were added to all the right roles, but we forgot to remove the visibility flag. We removed that flag yesterday afternoon - unfortunately, for production safety reasons, IAM rollouts take a few days. We're tracking this issue here #6593 and will update/close that once they are fully publicly available.

@tcf909
Copy link

tcf909 commented Dec 8, 2023

@joehan thank you for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants