-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouping functions doesn't work anymore in firebase-tools 12.6.0 with TS #6408
Comments
Can confirm this as well. I was using
After those functions were successfully deployed, Nodejs notified me that a new version of Then I ran the following command to continue deploy other functions:
But all the functions failed to deploy. And I got the same error as OP.
-- Edit 1:After I made this comment, I tried Edit 2:It seemed like I also tried to delete all the functions from |
Hi everyone, thanks for reporting this issue. I was able to replicate the behavior mentioned. I tried deploying the code snippet provided using import { onRequest } from 'firebase-functions/v2/https'
export const Hello = {
world: onRequest((req, res) => {
res.send('Hello World')
})
} However, after upgrading to Let me raise this to our engineering team so that they can take a look and investigate the issue. |
The last two versions (12.5.0 and 12.6.0) of firebase-tools have had critical bugs in them that should not have made it into a release. How are the firebase team looking to improve the release and testing process to ensure that these issues don't keep occurring? 2.5.0 issue: #6290 |
Hey all, fix is coming ASAP for this issue. This also highlighted a gap in our integration tests - we'll be adding coverage for function groups to catch issues like this in the future. |
The PR referred to above does not fix the issue. It does a |
Thanks for pointing this out @mortenbekditlevsen, |
[REQUIRED] Environment info
firebase-tools: 12.6.0
Platform: : Ubuntu
[REQUIRED] Test case
Grouping functions doesn't work anymore in firebase-tools 12.6.0
[REQUIRED] Steps to reproduce
Init a firebase project with Typescript.
Write index.ts:
[REQUIRED] Expected behavior
Install [email protected]
Deploy the function
firebase deploy --only functions
It works:
[REQUIRED] Actual behavior
Install [email protected]
Deploy the function
firebase deploy --only functions
It fail:
CloudRun Logs:
The text was updated successfully, but these errors were encountered: