Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ALLOWED_SSR_REGIONS constant for web frameworks #6086

Closed
wants to merge 9 commits into from
Closed

Update ALLOWED_SSR_REGIONS constant for web frameworks #6086

wants to merge 9 commits into from

Conversation

jamesxabregas
Copy link
Contributor

Description

Update list of ALLOWED_SSR_REGIONS in web frameworks config to include the current list of regions that support gen 2 Cloud Functions.

#5504 added the ability to select an SSR region other than 'us-central1', but it was limited to regions that supported Gen 2 Cloud Functions at the time which has since expanded. This change updates the list of supported regions.

Scenarios Tested

Tested deploying to new regions using config in firebase.json

frameworksBackend": {
      "region": "australia-southeast1"
}

Sample Commands

Commands have not changed.

As per previous functionality, run:

firebase experiments:enable webframeworks
firebase init hosrting
firebase deploy

@jamesxabregas
Update list of ALLOWED_SSR_REGIONS in web frameworks config to incl…
db00c5c 
…ude the current list of regions that support gen 2 Cloud Functions.
@google-cla
Copy link

google-cla bot commented Jul 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jamesxabregas
Copy link
Contributor Author

Just wondering if there is any particular reason this hasn't been reviewed yet? I filled in the Google CLA and re-scanned. Are there some additional steps I need to take?

@eXodes eXodes mentioned this pull request Aug 9, 2023
Closed
@alexastrum alexastrum self-requested a review August 15, 2023 20:20
@alexastrum
Copy link
Contributor

Sorry for the delay. LGTM

@alexastrum alexastrum enabled auto-merge (squash) August 15, 2023 20:22
@jamesxabregas
Copy link
Contributor Author

Hi maintainers, just wondering if there is something in particular I need to do to get this change merged?
It was approved 3 weeks ago but still waiting to be merged.

@al4nnw
Copy link

al4nnw commented Sep 18, 2023 •
edited
Loading

@alexastrum My project is starting to generate some fees related to intercontinental network egress.

V2 functions are already supported in a lot of regions.

Could we get this merged?

@jamesxabregas
Copy link
Contributor Author

@alexastrum could you please merge these changes, or tell me what needs to be done to progress this. Thank you.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (67f7480) 54.69% compared to head (f7f34e3) 54.70%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6086   +/-   ##
=======================================
  Coverage   54.69%   54.70%           
=======================================
  Files         346      346           
  Lines       23670    23670           
  Branches     4870     4870           
=======================================
+ Hits        12946    12948    +2     
+ Misses       9531     9529    -2     
  Partials     1193     1193
Files Changed Coverage Δ
src/frameworks/constants.ts 82.60% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eXodes
Copy link

eXodes commented Nov 1, 2023

@jamesxabregas It seems that the fork master is outdated. Could you please help merge the latest firebase-tools?

@jamesxabregas
Copy link
Contributor Author

@jamesxabregas It seems that the fork master is outdated. Could you please help merge the latest firebase-tools?

@eXodes I updated master in my fork. Now what?

@eXodes
Copy link

eXodes commented Nov 2, 2023

Paging @alexastrum for approval.

@jamesdaniels jamesdaniels mentioned this pull request Dec 7, 2023
Merged
@jamesdaniels
Copy link
Member

Closing in favor of #6591

auto-merge was automatically disabled December 7, 2023 17:12

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexastrum alexastrum alexastrum approved these changes

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

Assignees
No one assigned
Labels
integration: web frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jamesxabregas @alexastrum @al4nnw @codecov-commenter @eXodes @jamesdaniels