-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console.log "heartbeats" is unnecessary #8436
Comments
Appears to have been introduced with #8425 |
Same, but in a react app and it's super noisy in the logs and in local dev.
|
Same problem. |
Hi @tzappia, thank for bringing this to our attention. I was able to reproduce the behavior. Let me check what we can do for this issue or bring someone here that can provide more context about it. I’ll update this thread if I have any information to share. |
Experiencing the same issue when I just updgraded to |
Thanks for reporting this! This was introduced in 10.13.0, so if anyone wants to get rid of this they can downgrade to 10.12.5 until the removal of the |
|
Are you seeing this in 10.12.4? The PR was merged into the 10.13 release here #8426 |
No, but I see it in 10.12.5 |
Sorry, I meant 10.12.5. I just tested this, and I am seeing it in 10.13.0, but not 10.12.5. Could you share what version of Looking at https://www.gstatic.com/firebasejs/10.13.0/firebase-app.js there is a |
@dlarocque Apologies, I must've been mistaken. Indeed, 10.12.5 does NOT display the "heartbeats" logs. |
Seeing this as well in version
Coming from these lines:
|
This was removed in #8437, which will be released next thursday (08/29). I'll keep this issue open until it's released. Thanks everyone for +1'ing this |
a tip: we have an eslint rule that errors on console.log so that it forces temporary usage. for permanent logs we use console.info/warn/error. |
This is a temporary workaround. Insert this snippet at the beginning of your main JavaScript file (e.g., index.js, main.js, etc.) or wherever you initialize Firebase:
|
This is super annoying. How can this happen? |
doesn't eslint caches this kind of things? how did it pass the CI? (asking for next time) |
Great! I'm looking forward to the update
|
The fix for this was released in 10.13.1 today. |
Great Success |
Operating System
macOS 14.6.1
Browser Version
Chrome/127.0.6533.120
Firebase SDK Version
10.13.0
Firebase SDK Product:
Auth, Firestore, Functions, Storage
Describe your project's tooling
Angular v18 app
Describe the problem
During initialization, an unhelpful console.log is repeated:
heartbeats undefined
Steps and code to reproduce issue
After initializing the app, initialize Firestore (for example)
The text was updated successfully, but these errors were encountered: