Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isEqual doesn't work on arrayUnion, arrayRemove, and increment #7706

Closed
marcusx2 opened this issue Oct 18, 2023 · 1 comment · Fixed by #7861
Closed

isEqual doesn't work on arrayUnion, arrayRemove, and increment #7706

marcusx2 opened this issue Oct 18, 2023 · 1 comment · Fixed by #7861
Assignees
@MarkDuckworth
Labels
api: firestore feature request

Comments

@marcusx2
Copy link

Operating System

macOS

Browser Version

Safari 16.5.2

Firebase SDK Version

10.5.0

Firebase SDK Product:

Firestore

Describe your project's tooling

index.html with source tag. Just javascript.

Describe the problem

isEqual doesn't work on arrayUnion, arrayRemove, and increment. They always return false, even when they are equal.

Steps and code to reproduce issue

console.log(arrayUnion().isEqual(arrayUnion()));//return false
console.log(arrayRemove().isEqual(arrayRemove()));//return false
console.log(increment().isEqual(increment()));//return false
@marcusx2 marcusx2 added new A new issue that hasn't be categoirzed as question, bug or feature request question labels Oct 18, 2023
@marcusx2 marcusx2 changed the title Title for the bug isEqual doesn't work on arrayUnion, arrayRemove, and increment Oct 18, 2023
@jbalidiong jbalidiong added needs-attention and removed new A new issue that hasn't be categoirzed as question, bug or feature request labels Oct 18, 2023
@MarkDuckworth MarkDuckworth self-assigned this Oct 19, 2023
@MarkDuckworth
Copy link
Contributor

Thanks for reporting this. I investigated and found some old TODOs in the code for these isEqual methods. I've opened a new internal feature request to get this implemented.

Internal tracking b/306399547

@milaGGL milaGGL mentioned this issue Dec 12, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MarkDuckworth MarkDuckworth

Labels
api: firestore feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update isEqual for arrayUnion, arrayRemove, and increment firebase/firebase-js-sdk
5 participants
@MarkDuckworth @marcusx2 @DellaBitta @google-oss-bot @jbalidiong