Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in GtagConfigParams #6349

Closed
piotrponikowski opened this issue Jun 10, 2022 · 2 comments
Closed

Typo in GtagConfigParams #6349

piotrponikowski opened this issue Jun 10, 2022 · 2 comments
Labels
api: analytics

Comments

@piotrponikowski
Copy link

I was checking typings of GtagConfigParams, and looks like there is a typo in:

firebase-js-sdk/packages/analytics/src/public-types.ts

Line 73 in 11d37ed

'allow_google_signals?': boolean;

My first thought was, that this param is really named allow_google_signals?, however checked with docs and correct name is just allow_google_signals: https://developers.google.com/analytics/devguides/collection/gtagjs/display-features

Another attribute for comparison looks ok:

firebase-js-sdk/packages/analytics/src/public-types.ts

Line 78 in 11d37ed

'allow_ad_personalization_signals'?: boolean;

@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@dwyfrequency dwyfrequency mentioned this issue Jun 10, 2022
Merged
@dwyfrequency
Copy link
Contributor

Merged a PR for this

@firebase firebase locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: analytics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dwyfrequency @google-oss-bot @piotrponikowski @paulinon