Use idb 7 for products using shared idb library #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61bfd0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (608,208 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Changeset File Check ✅
|
hsubox76
requested review from
egilmorez,
avolkovi,
yoyomyo,
zwu52 and
allspain
as code owners
| interface InstallationsDB extends DBSchema { | ||
| 'firebase-installations-store': { | ||
| key: string; | ||
| value: InstallationEntry | undefined; |
There was a problem hiding this comment.
Do we prefer this style of optionals instead of value?: InstallationEntry;?
There was a problem hiding this comment.
It would be better to do value?: InstallationEntry but unfortunately we're extending a type from the external idb library and that type doesn't allow value to be an optional property (but does allow | undefined):
https://github.com/jakearchibald/idb/blob/231942c8a6b425e799e22885afb88751df4432ca/src/entry.ts#L124
Merged
|
9.8.0 also introduces this issue (not present in 9.7.0) in React Native builds. Regards |
|
I am finding the same error as @edi |
|
Someone opened the same issue here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Until recently, we were using the external
idbdependency for app, installations, and messaging. (This also effectively made it a dependency of analytics, performance, and remote-config, as they depend on the installations package.) However, because we were required to support IE, we had to pin theidbversion to 3.0.2, as subsequent versions ofidbno longer supported IE. Sinceidbis currently on version 7+, this has caused a number of issues, most recently with lack of named exports causing problems with Angular.We made a temporary fix to replace
idbentirely with our own stopgap code in #6061Since we are planning to drop IE support at I/O, we can now put the
idbdependency back and bump it to 7+, which should have named exports and the Nodeexportsfield and support ESM.