Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighthouse Report Issue with auth iframe #5631

Closed
StefanBratanov opened this issue Oct 18, 2021 · 4 comments · Fixed by #5633 or #5700
Closed

Lighthouse Report Issue with auth iframe #5631

StefanBratanov opened this issue Oct 18, 2021 · 4 comments · Fixed by #5633 or #5700
Labels
api: auth v9

Comments

@StefanBratanov
Copy link

[REQUIRED] Describe your environment

  • Operating System version: 10
  • Browser version: Chrome 94.0.4606.81
  • Firebase SDK version: 9.1.1
  • Firebase Product: auth

[REQUIRED] Describe the problem

Hi, i am running into a Lighthouse issue stating that iframe element does not have a title. Please refer to the attached image. Can you please advise? I am using facebook, google, twitter as social sign ins which open a popup so it may be issue with that.

image

Steps to reproduce:

Run a Lighthouse Report on website using Firebase auth and facebook, google, twitter as social sign ins.
@jbalidiong jbalidiong added the v9 label Oct 18, 2021
@sam-gc sam-gc mentioned this issue Oct 18, 2021
Merged
This was referenced Oct 19, 2021
Merged
Merged
@StefanBratanov
Copy link
Author

StefanBratanov commented Oct 30, 2021 •
edited
Loading

Hi, i upgraded to latest version 9.2.0 and wanted to let you know i get a different lighthouse issue now.

image

@sam-gc
Copy link
Contributor

sam-gc commented Nov 1, 2021

There's nothing in that iframe that will ever need to be interacted with. I'm not sure how to indicate to lighthouse that this is intentional. I will do some digging

@sam-gc sam-gc reopened this Nov 1, 2021
@StefanBratanov
Copy link
Author

There's nothing in that iframe that will ever need to be interacted with. I'm not sure how to indicate to lighthouse that this is intentional. I will do some digging

Thank you! Are you able to replicate the lighthouse issue in your environment? It may be an issue on my side.

@sam-gc
Copy link
Contributor

sam-gc commented Nov 4, 2021

I am able to replicate, a fix is on the way!

@sam-gc sam-gc mentioned this issue Nov 4, 2021
Merged
@google-oss-bot google-oss-bot mentioned this issue Nov 8, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: auth v9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Auth] Add aria-hidden='true' attribute to embedded iframe firebase/firebase-js-sdk
[Auth] Add tabindex=-1 to iframe to fix issue with aria-hidden firebase/firebase-js-sdk
4 participants
@sam-gc @StefanBratanov @google-oss-bot @jbalidiong