Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS Firebase Auth Cannot fetch to Auth url Capacitor 3 #5020

Closed
riderx opened this issue Jun 12, 2021 · 18 comments
Closed

CORS Firebase Auth Cannot fetch to Auth url Capacitor 3 #5020

riderx opened this issue Jun 12, 2021 · 18 comments
Labels
api: auth feature request internal-bug-filed

Comments

@riderx
Copy link
Contributor

riderx commented Jun 12, 2021

[REQUIRED] Describe your environment

  • Operating System version: IOS 14
  • Browser version: Capacitor 3
  • Firebase SDK version: json api
  • Firebase Product: auth

[REQUIRED] Describe the problem

Since I wasn't able to use auth sdk in capacitor i tried to do it by json API using :
https://github.com/samuelgozi/firebase-auth-lite/blob/d4ed969c9d7a9181910b14f05a6e1140b33448d0/src/main.js#L118

This work perfectly on web but not in Mobile app because of the capacitor origin .

[Error] Failed to load resource: Origin capacitor://localhost is not allowed by Access-Control-Allow-Origin. (token, line 0)
https://securetoken.googleapis.com/v1/token?key=****

Steps to reproduce:

Create a starter capacitor app with the code below

Relevant Code:

const signUp = () => {
    const apiKey ="***"
    const url = `https://securetoken.googleapis.com/v1/token?key=${apiKey}`;
    return fetch(url, {
        method: 'POST',
        body: JSON.stringify({returnSecureToken: true})
    }).then(async response => {
        let data = await response.json();
        // If the response returned an error, try to get a Firebase error code/message.
        // Sometimes the error codes are joined with an explanation, we don't need that(its a bug).
        // So we remove the unnecessary part.
        if (!response.ok) {
            const code = data.error.message.replace(/ ?: [\w ,.'"()]+$/, '');
            throw Error(code);
        }
        return data;
    });
}
signUp()
@sam-gc
Copy link
Contributor

sam-gc commented Jun 15, 2021

Thanks for pointing this out. Since this is unrelated to the particular SDK version, I'm going to remove the v9 label for now. I've filed an internal bug to track this, but unfortunately I can't make any predictions regarding timelines. (For Firebase folks: b/191185030)

@sam-gc sam-gc added feature request and removed v9 labels Jun 15, 2021
@riderx
Copy link
Contributor Author

riderx commented Jun 15, 2021

@sam-gc thanks for the answer, I see in the doc you support Cordova so I supposed you support capacitor since all (most) modules are cross-compatible.
Thanks to filled a bug, with your answer in #5019 I should be able to use v9 thanks a lot!

@riderx riderx mentioned this issue Jun 15, 2021
Closed
@riderx
Copy link
Contributor Author

riderx commented Jun 15, 2021

Look like others got the issue : capacitor-community/firebase-analytics#54

@riderx
Copy link
Contributor Author

riderx commented Jun 15, 2021

@sam-gc if you need the ionic team documented well the cors here : https://ionicframework.com/docs/troubleshooting/cors
Capacitor
Platform Origin
iOS capacitor://localhost
Android http://localhost

Ionic WebView 3.x plugin on Cordova
Platform Origin
iOS ionic://localhost
Android http://localhost

Ionic WebView 2.x plugin on Cordova
Platform Origin
iOS http://localhost:8080
Android http://localhost:8080

@riderx
Copy link
Contributor Author

riderx commented Jul 14, 2021

@sam-gc please, my apps are broken because of that :/

@1x2x3x4x
Copy link

Any news?

@bdhwan
Copy link

bdhwan commented Oct 6, 2021

same issue. firebase 7.x works well. but 9.x not working because capacitor://

@simonpeters
Copy link

Anyone found a fix for this?

@m8xp0w3r
Copy link

Having the same issue. If anyones found a solution, please add it here. Thanks in advance.

@phpfs
Copy link

phpfs commented Apr 2, 2022

This fixed it for me: https://harryherskowitz.com/2021/08/23/firebase-capacitor.html

@riderx
Copy link
Contributor Author

riderx commented Apr 3, 2022

my solution was to remove Firebase and use Supabase instead, they care about people who use they tools

@wmadden
Copy link

wmadden commented May 3, 2022

It looks like the issue is Firebase incorrectly detecting the environment (see @alistairheath's comment here).

There's a check in the auth/compat library here which checks for the URL scheme "ionic://", which was used by older versions of Capacitor (it's now "capacitor://") and if you set it back to "ionic://" (see the config option iosScheme) it seems to work again and doesn't attempt to load the gapi libraries.

TL;DR, in capacitor.config set server: { iosScheme: "ionic" }

@mesqueeb
Copy link

mesqueeb commented May 4, 2022

@wmadden can you please make a PR to fix this ?

@riderx
Copy link
Contributor Author

riderx commented May 5, 2022

@mesqueeb done here : #6236

@riderx riderx mentioned this issue May 9, 2022
Merged
@riderx
Copy link
Contributor Author

riderx commented May 23, 2022

The Pr is merged ! It will come soon in production !

@michaeljelly
Copy link

michaeljelly commented Jun 7, 2022 •
edited
Loading

How soon is soon? (@mesqueeb) This is blocking an release/launch so it would be great to have a timeline, let me know if there's anything I can track.
Thanks so much for your work on fixing this up @riderx

@riderx
Copy link
Contributor Author

riderx commented Jun 7, 2022 •
edited
Loading

@michaeljelly it has been released the 27 of may in the 9.8.2 👌
https://firebase.google.com/support/release-notes/js

@michaeljelly
Copy link

Awesome, turns our I had a different problem where I wasn't initialising the app properly, which I have now fixed! So all good.
Thanks!

@riderx riderx closed this as completed Jun 11, 2022
@firebase firebase locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: auth feature request internal-bug-filed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests