Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth emulator not used with currentUser.linkWithPopup #4879

Closed
patelnav opened this issue May 7, 2021 · 4 comments · Fixed by #4966
Closed

Auth emulator not used with currentUser.linkWithPopup #4879

patelnav opened this issue May 7, 2021 · 4 comments · Fixed by #4966
Assignees
@sam-gc @yuchenshi
Labels
api: auth internal-bug-filed testing-sdk testing with emulator

Comments

@patelnav
Copy link

patelnav commented May 7, 2021

[REQUIRED] Describe your environment

  • Operating System version: macOS 11.3.1 (20E241)
  • Browser version: Version 90.0.4430.93 (Official Build) (x86_64)
  • Firebase SDK version: 9.10.2
  • Firebase Product: auth

[REQUIRED] Describe the problem

currentUser.linkWithPopup doesn't use auth emulator, instead going to accounts.google.com

Steps to reproduce:

Enable emulator using auth.useEmulator(...)
Login with auth.signInAnonymously()
Attempt to link with popup

auth.currentUser.linkWithPopup(new firebase.auth.GoogleAuthProvider())
PROBLEM:

Screen Shot 2021-05-07 at 12 48 54 AM

Note: javascript auth.signInWithPopup(new firebase.auth.GoogleAuthProvider()) (skipping anonymous login) works as desired:
Screen Shot 2021-05-07 at 12 49 25 AM
@looptheloop88 looptheloop88 added the testing-sdk testing with emulator label May 7, 2021
@looptheloop88
Copy link

looptheloop88 commented May 10, 2021 •
edited
Loading

Hi @patelnav, thanks for the report and apologies for the delay in response. I was able to replicate the issue where linkWithPopup() isn't working with emulator after successful authentication using signInAnonymously().

While I'm still investigating the issue, could you check and provide any error logs generated from the browser console?

@looptheloop88
Copy link

Hi @patelnav, I've filed an internal bug for this issue, however we can't provide definite timelines or details for when it will be fixed. You may keep an eye out on our release notes or check this issue thread for any updates in the future.

@patelnav
Copy link
Author

Hey sorry, meant to follow up on your request for error logs. There are no error logs pertaining to this as far as I can tell.

Please do prioritize this bug appropriately. It makes it very difficult to test escalation of anonymous users to logged in ones without a fix. Thanks!

@Feiyang1 Feiyang1 assigned sam-gc and yuchenshi and unassigned Feiyang1 May 13, 2021
@ekzhang ekzhang mentioned this issue May 18, 2021
Closed
@weixifan
Copy link

For internal reference: the internal bug is b/188039872.

@sam-gc sam-gc mentioned this issue Jun 2, 2021
Merged
@google-oss-bot google-oss-bot mentioned this issue Jun 16, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sam-gc sam-gc

@yuchenshi yuchenshi

Labels
api: auth internal-bug-filed testing-sdk testing with emulator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Auth] Update user to plumb through emulator config firebase/firebase-js-sdk
7 participants
@patelnav @sam-gc @Feiyang1 @yuchenshi @google-oss-bot @weixifan @looptheloop88