-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCM rxjs compatibility broken? #3142
Comments
ref: FCM API |
Reading angular/angularfire#2299 (comment), seems it was working before |
Finally got a chance to route back to this. I think I found the cause for this: currently window controller stores a member variable {
next: (msg) => handleForegroundMessage(msg),
error: (err) => console.log("err: " + err),
} However, rxjs actually does some internal operation and converts the observer into a subscriber instance, such instance should be used as a unit as it is (e.x. this.onMessageCallback = function: ƒ (value) {
if (!this.isStopped) {
this._next(value);
}
} since next is stripped away from the generated subscriber, |
perfect, I'm coming from angular/angularfire#2497 (comment) and I'm wating for your fix to update my PR |
FCM API suggests that it offers rxjs compatibility out of box. Specifically, you could do
However, an error is thrown:
Came across this error here as well (angular/angularfire#2299)
The text was updated successfully, but these errors were encountered: