Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firebase-bom renders no dependency from firebase-firestore-ktx to firebase-firestore-ktx #5339

Closed
drindt opened this issue Sep 15, 2023 · 5 comments
Closed

firebase-bom renders no dependency from firebase-firestore-ktx to firebase-firestore-ktx #5339

drindt opened this issue Sep 15, 2023 · 5 comments
Labels
api: firestore type: bug Something isn't working

Comments

@drindt
Copy link

drindt commented Sep 15, 2023 •
edited
Loading

[REQUIRED] Step 2: Describe your environment

  • Android Studio version: #AI-231.9392.1.2311.10779794
  • Firebase Component: Firestore
  • Component version: 24.8.0

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

I define in my build.gradle.kts the firebase-firestore-ktx and the firebase-bom where the bom defines version 32.3.0. This includes then the firebase-firestore-ktx with version 24.8.0.

Relevant Code:

By using this version, this construct no longer work:

val firestore = Firebase.firestore

You need to declare firebase-firestore in the dependencies too. Which was not required before in version 32.2.3.
This doesn't match to the statement here:
https://firebase.google.com/docs/android/learn-more#ktx
@argzdev
Copy link
Contributor

argzdev commented Sep 15, 2023

Thanks for reporting, @drindt. I was able to reproduce the same behavior. Let me notify our engineers and see what we can do about this.

@argzdev argzdev added the type: bug Something isn't working label Sep 15, 2023
@szykam
Copy link

szykam commented Sep 15, 2023

Problem with new BOM may be broader as I had same issue with com.google.firebase:firebase-crashlytics-ktx. With 32.3.0 I had to add com.google.firebase:firebase-crashlytics dependency.

@thatfiredev
Copy link
Member

Sorry that you folks ran into this.
FYI The issue happens with the following libraries:

  • firebase-crashlytics-ktx
  • firebase-firestore-ktx
  • firebase-inappmessaging-ktx
  • firebase-inappmessaging-display-ktx

A fix has been merged in #5337 and a new version of the BoM should be released soon.

@thatfiredev
Copy link
Member

Hey all,
This has been fixed in the Firebase BoM 32.3.1
Thanks for you patience!

@drindt
Copy link
Author

drindt commented Sep 17, 2023

That was more than quick, thank you guys.

@firebase firebase locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: firestore type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@drindt @szykam @thatfiredev @google-oss-bot @argzdev