Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML Model Downloader is giving wrong exception #4157

Closed
sandeep5193 opened this issue Sep 30, 2022 · 7 comments
Closed

ML Model Downloader is giving wrong exception #4157

sandeep5193 opened this issue Sep 30, 2022 · 7 comments
Labels
api: mlkit

Comments

@sandeep5193
Copy link

sandeep5193 commented Sep 30, 2022 •
edited
Loading

Step 2: Describe your environment

  • Android Studio version: Dolphin, 2021.3.1
  • Firebase Component: firebase-ml-modeldownloader
  • Component version: 24.0.5

Step 3: Describe the problem

In 2 situations, model download is failing.

  1. for some reason, it has started to fail on my WiFi connection, while on mobile data it works. this has started recently.
  2. when model name passed is empty string.

while there can be a problem with the network, and of course in point no 2 it should fail, but error message it is giving is misleading.

Error message for Empty model name:
Permission error while fetching model (): HTTP response from Firebase Download Service: [401 - Unauthorized: API keys are not supported by this API. Expected OAuth2 access token or other authentication credentials that assert a principal. See https://cloud.google.com/docs/authentication]

And yes, I have restricted my API key with debug/release keys.

Steps to reproduce:

restrict API key with android app's debug/release key, send modelName as empty string to getModel() method.

Relevant Code:

FirebaseModelDownloader.getInstance(FirebaseApp.getInstance())
                .getModel("", DownloadType.LOCAL_MODEL, conditions)
@google-oss-bot
Copy link
Contributor

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@sandeep5193 sandeep5193 changed the title modeldownloader ML Model Downloader is giving wrong exception Sep 30, 2022
@argzdev
Copy link
Contributor

argzdev commented Oct 3, 2022

Thanks for reporting, @sandeep5193. Just to clarify so I don't get it wrong, how did you "restrict API key with android app's debug/release key"? Can you walk me through the steps?

Also I wonder, does passing an empty string to the getModel() work if the API is not restricted?

Thanks!

@sandeep5193
Copy link
Author

sandeep5193 commented Oct 3, 2022 •
edited
Loading

I have restricted the API key used for this project with these steps.

I have not tried passing an empty string to that method when API key is not restricted, this is a prod setup, I cannot test that.

@argzdev
Copy link
Contributor

argzdev commented Oct 4, 2022 •
edited
Loading

Thanks for the extra details, @sandeep5193. I was able to reproduce the same behavior. I'll notify our engineers and see what we can do here. Thanks!

Just some notes here. The point of entry of the issue is here:

firebase-android-sdk/firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/CustomModelDownloadService.java

Lines 151 to 153 in ee13f03

URL url =
new URL(String.format(DOWNLOAD_MODEL_REGEX, downloadHost, projectNumber, modelName));
HttpURLConnection connection = (HttpURLConnection) url.openConnection();

Which triggers the following error code:

firebase-android-sdk/firebase-ml-modeldownloader/src/main/java/com/google/firebase/ml/modeldownloader/internal/CustomModelDownloadService.java

Line 275 in ee13f03

case HttpURLConnection.HTTP_UNAUTHORIZED:

@Sankyuubigan
Copy link

i updated fierbase libs and now i have this error. very bad. have you any workaround temporary case ?

@argzdev
Copy link
Contributor

argzdev commented Oct 13, 2022 •
edited
Loading

Hi @Sankyuubigan, are you pertaining to the wifi/mobile data issue? Can you share what was the previous version you were using? Also what error are you receiving? Can you also provide code snippets or MCVE? Thanks!

This was referenced Oct 19, 2022
Closed
Merged
@argzdev
Copy link
Contributor

argzdev commented Oct 21, 2022

Hi @sandeep5193, we've added a new exception handler for empty strings. The fix would be available in the next upcoming release. That said, I'll close this issue now.

@argzdev argzdev closed this as completed Oct 21, 2022
@firebase firebase locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: mlkit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sandeep5193 @Sankyuubigan @google-oss-bot @argzdev