Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in datatransport com.google.android.datatransport.runtime.logging.Logging #3716

Closed
gevorg-kopalyan opened this issue May 11, 2022 · 9 comments · Fixed by #3728 or #3822
Closed

Crash in datatransport com.google.android.datatransport.runtime.logging.Logging #3716

gevorg-kopalyan opened this issue May 11, 2022 · 9 comments · Fixed by #3728 or #3822
Labels
api: core type: bug Something isn't working

Comments

@gevorg-kopalyan
Copy link

gevorg-kopalyan commented May 11, 2022 •
edited
Loading

[READ] Step 1: Are you in the right place?

yes

[REQUIRED] Step 2: Describe your environment

  • Android Studio version: Android Studio Bumblebee | 2021.1.1 Patch 3
  • Firebase Component: Analytics, Auth, Performance, Dynamic links, Crashlytics, Remote Config, Messaging
  • Component version: Bom 30.0.0

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

Getting crashes in google play console but not in Firebase Crashlytics

java.lang.IllegalArgumentException: Log tag "TransportRuntime.Executor" exceeds limit of 23 characters

  at android.util.Log.isLoggable (Native Method)
  at com.google.android.datatransport.runtime.logging.Logging.e (Logging.java:63)
  at com.google.android.datatransport.runtime.SafeLoggingExecutor$SafeLoggingRunnable.run (SafeLoggingExecutor.java:49)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1133)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:607)
  at java.lang.Thread.run (Thread.java:776)

In com.google.android.datatransport:transport-runtime Library which firebase datatrasport library is using has a new Log.isLoggable() check which doesn't check for a tag limit of 23 characters and can produce crash.
Here is the pull request that added new Log.isLoggable check
@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@darrentaft
Copy link

Glad it's not just me! Had to immediately roll back to 29.3.1. Thanks for raising.

@argzdev
Copy link
Contributor

argzdev commented May 12, 2022

Thanks for reporting, @gevorg-kopalyan, @darrentaft. I'll notify our engineers and see what we can do here.

@argzdev argzdev added the type: bug Something isn't working label May 12, 2022
@vlad-roid
Copy link

This is bad, it's hitting affected users repeatedly. So far only 11 people in our app are affected, but each person has been hit by the crash over 50 times! I assume this happens on app trying to auto-start, I can't imagine someone having the patience to try and open an app 50 times.

image

This was referenced May 16, 2022
Closed
Merged
@AliA74
Copy link

AliA74 commented May 20, 2022

I am facing the same issue. I know this issue has been fixed in the source code but how can I as a Unity game developer using Firebase-SDK fix this issue? Has there been any new release that I can use? Either for Android or Unity.

@argzdev
Copy link
Contributor

argzdev commented May 20, 2022

Hi @AliA74, we expect this fix to be in a release that is targeted for next week. You can keep an eye on our release notes for bug fixes and features. As for Firebase SDK for the Unity platform, afaik it should be available once it's been released for Android.

@aman-reso
Copy link

How you guy's resolve this Crash

@AliA74
Copy link

AliA74 commented May 23, 2022

@aman-reso

I used ProGuard to remove isLoggable calls. Add something similar to your proguard file:

-assumenosideeffects class android.util.Log { static *** isLoggable(...); }

@carlonzo
Copy link
Contributor

the fix for this has been released as part of BOM 30.0.2 https://firebase.google.com/support/release-notes/android#bom_v30-0-2

@threos threos mentioned this issue Jun 1, 2022
Closed
@dbrant dbrant mentioned this issue Jun 13, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: core type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shortened prefix and capped concatenated string
Changing condition statement API version < 26 for log limit
Issue 3716 shorten logging
8 participants
@carlonzo @gevorg-kopalyan @AliA74 @vlad-roid @google-oss-bot @darrentaft @aman-reso @argzdev