Firebase Auth crash when R8 full mode obfuscation enabled #2124

audkar · 2020-10-31T11:15:34Z

[READ] Step 1: Are you in the right place?

Y

[REQUIRED] Step 2: Describe your environment

Android Studio version: 4.0
Firebase Component: Auth
Component version: 20.0.0

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

If application is build with android.enableR8.fullMode=true then crash happens during login using google Sign-in.
With setting android.enableR8.fullMode=false app runs fine.

Stacktrace:

Fatal Exception: com.google.firebase.FirebaseException: An internal error has occurred. [ Instantiation of JsonResponse failed! class com.google.android.gms.internal.firebase-auth-api.zzok ]
       at com.google.firebase.auth.api.internal.zzem.zza(com.google.firebase:firebase-auth@@20.0.0:29)
       at com.google.firebase.auth.api.internal.zzfx.zza(com.google.firebase:firebase-auth@@20.0.0:14)
       at com.google.firebase.auth.api.internal.zzfs.zza(com.google.firebase:firebase-auth@@20.0.0:44)
       at com.google.firebase.auth.api.internal.zzel.zza(com.google.firebase:firebase-auth@@20.0.0:10)
       at com.google.firebase.auth.api.internal.zzac.zza(com.google.firebase:firebase-auth@@20.0.0:2)
       at com.google.android.gms.common.util.DeviceProperties.zza(com.google.android.gms:play-services-basement@@17.1.1:131)
       at com.google.firebase.auth.api.internal.zzfn.zza(com.google.firebase:firebase-auth@@20.0.0:10)
       at com.google.firebase.auth.api.internal.zzep.zza(com.google.firebase:firebase-auth@@20.0.0:53)
       at com.google.firebase.auth.api.internal.zzda.accept(com.google.firebase:firebase-auth@@20.0.0:9)
       at com.google.android.gms.common.api.internal.zaf.zac(com.google.android.gms:play-services-base@@17.1.0:6)
       at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zac(com.google.android.gms:play-services-base@@17.1.0:2)
       at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zab(com.google.android.gms:play-services-base@@17.1.0:5)
       at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zaa(com.google.android.gms:play-services-base@@17.1.0:5)
       at com.google.android.gms.common.api.internal.GoogleApiManager.handleMessage(com.google.android.gms:play-services-base@@17.1.0:113)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at com.google.android.gms.internal.base.zar.dispatchMessage(com.google.android.gms:play-services-base@@17.1.0:1)
       at android.os.Looper.loop(Looper.java:223)
       at android.os.HandlerThread.run(HandlerThread.java:67)

Relevant Code:

val task = GoogleSignIn.getSignedInAccountFromIntent(result.data)
val account = task.getResult(ApiException::class.java)
val auth = FirebaseAuth.getInstance()
val credential = GoogleAuthProvider.getCredential(account.idToken, null)
val firebaseUser = auth.signInWithCredential(credential).await()

The text was updated successfully, but these errors were encountered:

google-oss-bot · 2020-10-31T11:15:41Z

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

malcolmdeck · 2020-11-02T20:02:33Z

Hey there! I've filed b/172259754 to track this internally :)

malcolmdeck · 2020-11-02T20:46:44Z

Ok, it appears that this only happens when you use android.enableR8.fullMode=true and not android.enableR8=true. That's a reasonable workaround while I figure out if there's a way to fix this.

To be noted: I think the root cause is a use of reflection at the network layer of the SDK. I don't yet know how to protect classes when using enableR8, so it's gonna take me a bit to see if this is a fixable problem via something like proguard rules or if I have to see if it's possible to fix the underlying issue itself.

b95505017 · 2020-12-02T10:00:58Z

@malcolmdeck Any update? I don't want to turn off full mode of R8 just because upgrading firebase sdk.

devaniumesh · 2020-12-18T12:29:43Z

same problem here. in firebase latest sdk. When using android.enableR8.fullMode=true . it's release version not working

valentynsmetanin · 2020-12-22T15:09:41Z

It's still reproducing with:
android.enableR8.fullMode=true
com.google.firebase:firebase-bom:26.2.0
com.google.firebase:firebase-auth-ktx

benjaminojanne · 2021-01-12T22:20:54Z

Hello
I found a solution to the problem today.
Go to proguard-rules.pro file and add this:

-keep class com.google.android.gms.internal.** { *; }

b95505017 · 2021-01-12T22:22:56Z

@benjaminojanne Thanks but I think that will keep so many redundant thinks.

b95505017 · 2021-02-04T08:41:35Z

@benjaminojanne It seems that you could specify to the path within auth library
-keep class com.google.android.gms.internal.firebase-auth-api.** { *; }

nuhkoca · 2021-06-29T23:14:50Z

Any update on this without requiring a path?

TeGlobal · 2021-09-16T13:53:06Z

Make sure you have these lines:

-keep public class com.google.firebase.** {*;}
-keep class com.google.android.gms.internal.** {*;}
-keepclasseswithmembers class com.google.firebase.FirebaseException

Thanks #2124 (comment)

eakteam · 2021-12-18T21:10:07Z

+1

ronsivan1 · 2022-02-16T11:10:32Z

Didn't solve it for me

iammannan · 2022-04-07T16:33:31Z

Make sure you have these lines:

-keep public class com.google.firebase.** {*;} -keep class com.google.android.gms.internal.** {*;} -keepclasseswithmembers class com.google.firebase.FirebaseException

Thanks #2124 (comment)

thanks, it works

ArcherEmiya05 · 2022-10-04T16:20:19Z

@benjaminojanne It seems that you could specify to the path within auth library -keep class com.google.android.gms.internal.firebase-auth-api.** { *; }

This show as error in proguard file, any idea why?

ArcherEmiya05 · 2022-10-04T16:31:22Z

Make sure you have these lines:

-keep public class com.google.firebase.** {*;} -keep class com.google.android.gms.internal.** {*;} -keepclasseswithmembers class com.google.firebase.FirebaseException

Thanks #2124 (comment)

Is the other rule really necessary? Currently even with this line only in rule seems to solve the issue already.
-keep class com.google.android.gms.internal.** { *; }

svenjacobs · 2023-04-14T08:02:36Z

Now that Android Studio Flamingo with AGP 8.0 enabled R8 full mode by default, I'm facing the same issue.

Is there any chance the auth library could provide R8 consumer rules in its artifact?

tekinarslan · 2023-04-20T09:03:10Z

@svenjacobs you can add these lines into proguard and it works.

-keep public class com.google.firebase.** {;}
-keep class com.google.android.gms.internal.** {;}
-keepclasseswithmembers class com.google.firebase.FirebaseException

svenjacobs · 2023-04-20T09:43:42Z

@svenjacobs you can add these lines into proguard and it works.

-keep public class com.google.firebase.** {;} -keep class com.google.android.gms.internal.** {;} -keepclasseswithmembers class com.google.firebase.FirebaseException

@tekinarslan I only added this line to my R8 rules as mentioned here and it works for me.

-keep class com.google.android.gms.internal.** { *; }

martinbonnin · 2023-04-22T17:31:44Z

In case a reproducer is needed, this is happening joreilly/Confetti (Pull Request to keep classes).
Same conditions as others: happened after bumping AGP to 8.

LeandroLCD · 2023-05-24T17:48:25Z

-keep public class com.google.firebase.** {*;}
-keep class com.google.android.gms.internal.** {*;}
-keepclasseswithmembers class com.google.firebase.FirebaseException

el problema me persiste al modificar el archivo proguar:

argzdev · 2023-05-24T18:17:53Z

Hi @LeandroLCD, not sure if this is the same issue. Could you file a new ticket with details from our template regarding your issue? Thanks!

LouisCAD · 2023-06-12T16:32:18Z

Hello, this is a particularly sneaky bug, a not nice at all pitfall that Google left on the path of developers AND users.

How close is this to be fixed on Firebase side?

LouisCAD · 2023-06-12T16:34:31Z

I mean, it was reported back in 2020, and despite reports, part of Google itself pulled the trigger to make R8 full mode default in STABLE Android Gradle Plugin, and other part of Google still hasn't reacted…

The consequences aren't great, please, prioritize this show-stopper.

prameshj · 2023-07-17T18:07:01Z

This has been fixed in https://firebase.google.com/support/release-notes/android#auth_v22-1-0

google-oss-bot added the needs-triage label Oct 31, 2020

vkryachko assigned malcolmdeck Nov 2, 2020

vkryachko added api: auth and removed needs-triage labels Nov 2, 2020

malcolmdeck added the internal-bug-filed label Nov 2, 2020

hvsimon mentioned this issue Dec 9, 2021

Json conversion failed when the app obfuscated #3227

Closed

argzdev mentioned this issue Mar 16, 2022

Your client does not have permission to get URL - signupNewUser #3529

Closed

argzdev mentioned this issue Apr 19, 2023

Instantiation of JsonResponse failed! class com.google.android.gms.internal.firebase-auth-api.x1 #4900

Closed

martinbonnin mentioned this issue Apr 22, 2023

Make Firebase work with AGP 8 and R8 full mode joreilly/Confetti#647

Merged

kajfik mentioned this issue May 2, 2023

Sign-in intent gets suck and never launched firebase/FirebaseUI-Android#2066

Open

kajfik mentioned this issue May 2, 2023

Firebase Auth UI (Phone) not working with Full Mode R8 enable firebase/FirebaseUI-Android#2067

Closed

prameshj closed this as completed Jul 17, 2023

thatfiredev mentioned this issue Jul 17, 2023

Fix the issue with firebase auth in r8 fullmode joreilly/Confetti#809

Merged

firebase locked and limited conversation to collaborators Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Firebase Auth crash when R8 full mode obfuscation enabled #2124

Firebase Auth crash when R8 full mode obfuscation enabled #2124

audkar commented Oct 31, 2020

google-oss-bot commented Oct 31, 2020

malcolmdeck commented Nov 2, 2020

malcolmdeck commented Nov 2, 2020

b95505017 commented Dec 2, 2020

devaniumesh commented Dec 18, 2020

valentynsmetanin commented Dec 22, 2020 •

edited

Loading

benjaminojanne commented Jan 12, 2021 •

edited

Loading

b95505017 commented Jan 12, 2021

b95505017 commented Feb 4, 2021

nuhkoca commented Jun 29, 2021

TeGlobal commented Sep 16, 2021 •

edited

Loading

eakteam commented Dec 18, 2021

ronsivan1 commented Feb 16, 2022

iammannan commented Apr 7, 2022

ArcherEmiya05 commented Oct 4, 2022

ArcherEmiya05 commented Oct 4, 2022

svenjacobs commented Apr 14, 2023

tekinarslan commented Apr 20, 2023

svenjacobs commented Apr 20, 2023

martinbonnin commented Apr 22, 2023

LeandroLCD commented May 24, 2023

argzdev commented May 24, 2023

LouisCAD commented Jun 12, 2023

LouisCAD commented Jun 12, 2023

prameshj commented Jul 17, 2023

Firebase Auth crash when R8 full mode obfuscation enabled #2124

Firebase Auth crash when R8 full mode obfuscation enabled #2124

Comments

audkar commented Oct 31, 2020

[READ] Step 1: Are you in the right place?

[REQUIRED] Step 2: Describe your environment

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

Relevant Code:

google-oss-bot commented Oct 31, 2020

malcolmdeck commented Nov 2, 2020

malcolmdeck commented Nov 2, 2020

b95505017 commented Dec 2, 2020

devaniumesh commented Dec 18, 2020

valentynsmetanin commented Dec 22, 2020 • edited Loading

benjaminojanne commented Jan 12, 2021 • edited Loading

b95505017 commented Jan 12, 2021

b95505017 commented Feb 4, 2021

nuhkoca commented Jun 29, 2021

TeGlobal commented Sep 16, 2021 • edited Loading

eakteam commented Dec 18, 2021

ronsivan1 commented Feb 16, 2022

iammannan commented Apr 7, 2022

ArcherEmiya05 commented Oct 4, 2022

ArcherEmiya05 commented Oct 4, 2022

svenjacobs commented Apr 14, 2023

tekinarslan commented Apr 20, 2023

svenjacobs commented Apr 20, 2023

martinbonnin commented Apr 22, 2023

LeandroLCD commented May 24, 2023

argzdev commented May 24, 2023

LouisCAD commented Jun 12, 2023

LouisCAD commented Jun 12, 2023

prameshj commented Jul 17, 2023

valentynsmetanin commented Dec 22, 2020 •

edited

Loading

benjaminojanne commented Jan 12, 2021 •

edited

Loading

TeGlobal commented Sep 16, 2021 •

edited

Loading