-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FirebaseCrashlytics log() method takes only a message without priority and tag #1202
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
Thank you for your answer, but I try to use the new implementation of FirebaseCrashlytics (without Fabric) |
Thanks for the clarification. It seems there should be another log() method with priority and tag as parameter, see here. The Firebase Crashlytics SDK for Android is still a beta release so there are still a few issues that need to be addressed. I'll be tagging this issue as bug for now. |
Thank you :) |
For now, you may try to log a message with tag using this syntax:
You can read more here. |
Yes it works, but like I said in my first message it's just not ideal because FirebaseCrashlytics.getInstance().log() calls the method log(msg) of CrashlyticsCore I'm going to use the library like that and I'll wait for an improvement. |
Issue is being tracked internally using bug#148943501. I'll keep you posted. |
Hi @lionel-dangelo I got feedback from our engineering team. It is intended behavior that priority and tag has been taken out in the Firebase Crashlytics SDK. We do log a priority and tag internally, but it's always "D/FirebaseCrashlytics,". We would like to ask your feedback on what you think of either of these changes to the log method:
Thanks. |
Thank you for your answer. So yes, I just think a good behavior could be stopping to log the superfluous "D/FirebaseCrashlytics" For the moment, I have this on the firebase console (with the last implementation) And if I download the .log file from firebase : |
Hi @lionel-dangelo We have implemented removing the uperfluous log and it will be released in beta02. Here's the pull request #1247. Thanks so much for the feedback. |
I am closing this issue for now. I'd recommend checking out our releae notes to see when a PR makes it into an official release. Any new features/breaking changes/bug fixes should be detailed there :) |
Why the only way to log something is FirebaseCrashlytics.getInstance().log(message) without tag and priority ? If we look the implementation, we see that this method calls the CrashlyticsCore method
public void log(String msg) { this.doLog(3, "FirebaseCrashlytics", msg); }
and this method sets always a the Debug priority (3) and the tag "FirebaseCrashlytics" which is not really readable in the firebase crash console.
Is this a bug ?
Thank you
The text was updated successfully, but these errors were encountered: