Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out fake_ifdh.py code into ifdh operations and credential operations #575

Open
shreyb opened this issue Sep 25, 2024 · 1 comment
Open

Separate out fake_ifdh.py code into ifdh operations and credential operations #575

shreyb opened this issue Sep 25, 2024 · 1 comment
Labels
cleanup General code cleanup and optimization

Comments

@shreyb
Copy link
Collaborator

shreyb commented Sep 25, 2024

In fake_ifdh.py, we have operations like getToken and getProxy. These really should be in creds.py or something similar, so that what's left in fake_ifdh.py is actually ifdh-simulating operations.
@shreyb shreyb added the cleanup General code cleanup and optimization label Sep 25, 2024
@marcmengel
Copy link
Contributor

Well, technically ifdh does have getToken and getProxy calls, but I see the argument for putting all the credentials stuff in creds.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup General code cleanup and optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcmengel @shreyb