Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 1244 + fix data path in medical brain segmentation notebook #1245

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix issue 1244 + fix data path in medical brain segmentation notebook #1245

merged 1 commit into from
Nov 21, 2024

Conversation

mvesin
Copy link
Member

@mvesin mvesin commented Nov 14, 2024

PR description

Developer Certificate Of Origin (DCO)

By opening this merge request, you agree to the
Developer Certificate of Origin (DCO)

This DCO essentially means that:

  • you offer the changes under the same license agreement as the project, and
  • you have the right to do that,
  • you did not steal somebody else’s work.

License

Project code files should begin with these comment lines to help trace their origin:

# This file is originally part of Fed-BioMed
# SPDX-License-Identifier: Apache-2.0

Code files can be reused from another project with a compatible non-contaminating license.
They shall retain the original license and copyright mentions.
The CREDIT.md file and credit/ directory shall be completed and updated accordingly.

Guidelines for PR review

General:

Specific to some cases:

  • update all conda envs consistently (development and vpn, Linux and MacOS)
  • if modified researcher (eg new attributes in classes) check if breakpoint needs update (breakpoint/load_breakpoint in Experiment(), save_state_breakpoint/load_state_breakpoint in aggregators, strategies, secagg, etc.)
  • if modified a component with versioning (config files, breakpoint, messaging protocol) then update the version following the rules in common/utils/_versions.py

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (a54dc02) to head (db1dbce).
Report is 14 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1245   +/-   ##
========================================
  Coverage    89.40%   89.41%           
========================================
  Files           98       98           
  Lines        10818    10822    +4     
========================================
+ Hits          9672     9676    +4     
  Misses        1146     1146
Flag Coverage Δ
unittests-fedora38 89.41% <100.00%> (+<0.01%) ⬆️
unittests-ubuntu-22-04 89.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@srcansiz srcansiz self-requested a review November 15, 2024 09:08
@srcansiz srcansiz merged commit 8e6c0dc into develop Nov 21, 2024
16 of 17 checks passed
@srcansiz srcansiz deleted the feature/fix-1244-and-misc-notebook branch November 21, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srcansiz srcansiz srcansiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requests.list() hanging
2 participants
@mvesin @srcansiz