Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services API is not escaping quotes in version comments causing json returned by the CLI to break. #1277

Open
guzmanbraso opened this issue Aug 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@guzmanbraso
Copy link

When someone uses quotes inside the comments of the versions published, the message inside the json does not escape quotes breaking json rules.

Comment example: 'Fix to point to the correct table "token_table"'

In the json translates into:
..."comment":"Fix to point to the correct table "token_table"","number":34...

This needs to be fixed on the API but was told by fastly to report it here.

@guzmanbraso guzmanbraso added the bug Something isn't working label Aug 9, 2024
@jsocol
Copy link
Member

jsocol commented Aug 9, 2024

Hi @guzmanbraso, thanks for this report! We're looking into it and will reach out with updates or if we need additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants