Remove some dead code in the assembler

DinoV · DinoV · commit 756ee689acd3 · 2021-01-28T11:14:38.000-08:00
Summary: There's some code (and a doc string) which says we need to convert from PyFlowGraph to code objects.  But that already happens in _convert_LOAD_CONST so this is just unnecessary.

Test Plan: ./python -m test.test_compiler
diff --git a/compiler/pyassem.py b/compiler/pyassem.py
@@ -657,17 +657,9 @@ def newCodeObject(self):
                         tuple(self.cellvars))
 
     def getConsts(self):
-        """Return a tuple for the const slot of the code object
-
-        Must convert references to code (MAKE_FUNCTION) to code
-        objects recursively.
-        """
-        l = []
-        for t, elt in self.consts:
-            if isinstance(elt, PyFlowGraph):
-                elt = elt.getCode()
-            l.append(elt)
-        return tuple(l)
+        """Return a tuple for the const slot of the code object"""
+        # Just return the constant value, removing the type portion.
+        return tuple(const[1] for const in self.consts)
 
 def isJump(opname):
     if opname[:4] == 'JUMP':
