refactor: status bar improvements (NativeScript#9154)

farfromrefug · web-flow · commit 963337e2e88c · 2021-01-29T12:06:00.000-08:00
diff --git a/packages/core/ui/page/index.ios.ts b/packages/core/ui/page/index.ios.ts
@@ -129,7 +129,7 @@ class UIViewControllerImpl extends UIViewController {
 			// because changes happen in an interactive transition - IOS will animate between the the states.
 			// If canceled - viewWillAppear will be called for the current page(which is already loaded) and we need to
 			// update the action bar explicitly, so that it is not left styles as the previous page.
-			owner.actionBar.update();
+			owner.updateWithWillAppear(animated);
 		}
 	}
 
@@ -221,6 +221,7 @@ class UIViewControllerImpl extends UIViewController {
 				owner.onNavigatingFrom(isBack);
 			}
 		}
+		owner.updateWithWillDisappear(animated);
 	}
 
 	@profile
@@ -368,6 +369,17 @@ export class Page extends PageBase {
 			this.actionBar.update();
 		}
 	}
+	updateWithWillAppear(animated: boolean) {
+		// this method is important because it allows plugins to react to modal page close
+		// for example allowing updating status bar background color
+		this.actionBar.update();
+		this.updateStatusBar();
+	}
+
+	updateWithWillDisappear(animated: boolean) {
+		// this method is important because it allows plugins to react to modal page close
+		// for example allowing updating status bar background color
+	}
 
 	public updateStatusBar() {
 		this._updateStatusBarStyle(this.statusBarStyle);

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ class UIViewControllerImpl extends UIViewController {`
`129`	`129`	`// because changes happen in an interactive transition - IOS will animate between the the states.`
`130`	`130`	`// If canceled - viewWillAppear will be called for the current page(which is already loaded) and we need to`
`131`	`131`	`// update the action bar explicitly, so that it is not left styles as the previous page.`
`132`		`- owner.actionBar.update();`
	`132`	`+ owner.updateWithWillAppear(animated);`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`
`@@ -221,6 +221,7 @@ class UIViewControllerImpl extends UIViewController {`
`221`	`221`	`owner.onNavigatingFrom(isBack);`
`222`	`222`	`}`
`223`	`223`	`}`
	`224`	`+ owner.updateWithWillDisappear(animated);`
`224`	`225`	`}`
`225`	`226`
`226`	`227`	`@profile`
`@@ -368,6 +369,17 @@ export class Page extends PageBase {`
`368`	`369`	`this.actionBar.update();`
`369`	`370`	`}`
`370`	`371`	`}`
	`372`	`+ updateWithWillAppear(animated: boolean) {`
	`373`	`+ // this method is important because it allows plugins to react to modal page close`
	`374`	`+ // for example allowing updating status bar background color`
	`375`	`+ this.actionBar.update();`
	`376`	`+ this.updateStatusBar();`
	`377`	`+ }`
	`378`	`+`
	`379`	`+ updateWithWillDisappear(animated: boolean) {`
	`380`	`+ // this method is important because it allows plugins to react to modal page close`
	`381`	`+ // for example allowing updating status bar background color`
	`382`	`+ }`
`371`	`383`
`372`	`384`	`public updateStatusBar() {`
`373`	`385`	`this._updateStatusBarStyle(this.statusBarStyle);`