Skip to content

Commit 4b96d4b

Browse files
committed
revert: perf(core): no need for batchUpdated if no selector (NativeScript#9121)
1 parent 6adcc40 commit 4b96d4b

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

packages/core/ui/styling/style-scope.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,10 @@ export class CssState {
473473

474474
const matchingSelectors = this._match.selectors.filter((sel) => (sel.dynamic ? sel.match(view) : true));
475475
if (!matchingSelectors || matchingSelectors.length === 0) {
476-
return;
476+
// Ideally we should return here if there are no matching selectors, however
477+
// if there are property removals, returning here would not remove them
478+
// this is seen in STYLE test in automated.
479+
// return;
477480
}
478481
view._batchUpdate(() => {
479482
this.stopKeyframeAnimations();

0 commit comments

Comments
 (0)