refactor: drop usage of strip-ansi in favor of node:util
#33086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Collaborator
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
tsapeta
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This drops
expo/expo-wide usage ofstrip-ansiin favor of Node's built inutil.stripVTControlCharacters.See facebook/metro@0f8cabd#diff-db9ae0866f1a1c4ec08fa483d2298b72c478453e15935b9df6539a98c1ad5c4bR185
Important
This doesn't fully get rid of
strip-ansi, it's often used as nested dependency.How
strip-ansiin favor ofnode:utils.Test Plan
See tests
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).