Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] TypeScript version doesn't have definition for Worksheet.addConditionalFormatting #1194

Closed
romanovma opened this issue Apr 1, 2020 · 1 comment
Closed

[BUG] TypeScript version doesn't have definition for Worksheet.addConditionalFormatting #1194

romanovma opened this issue Apr 1, 2020 · 1 comment

Comments

@romanovma
Copy link

🐛 Bug Report

I cannot find the way to use addConditionalFormatting() method on a Worksheet in TypeScript.

Lib version: 3.8.1

Steps To Reproduce

    const wb = await workbook.xlsx.readFile(
      `./template.xlsx`
    );

    const mySheet: Worksheet = wb.getWorksheet(1);
    mySheet.addConditionalFormatting({})

    // error TS2339: Property 'addConditionalFormatting' does not exist on type 'Worksheet'.

The expected behaviour:

Since it is supported in JS would be nice to have it in TS as well.
Alanscut added a commit to Alanscut/exceljs that referenced this issue Apr 3, 2020
@Alanscut
fix issue exceljs#1194
7d86a60
@Alanscut Alanscut mentioned this issue Apr 3, 2020
Merged
Siemienik added a commit that referenced this issue Apr 3, 2020
@Siemienik
Merge pull request #1199 from Alanscut/issue_1194
ecae225 
fix issue #1194 and update index.d.ts
@Siemienik
Copy link
Member

merged, available in v3.8.3 soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Siemienik @romanovma