Merge pull request #1344 from Alanscut/issue_1339

alubbe · web-flow · commit ec22202d6bd8 · 2020-06-19T10:14:37.000+02:00
[bugfix] Fix special cell values causing invalid files produced(#1339)
diff --git a/lib/utils/shared-strings.js b/lib/utils/shared-strings.js
@@ -2,7 +2,7 @@ class SharedStrings {
   constructor() {
     this._values = [];
     this._totalRefs = 0;
-    this._hash = {};
+    this._hash = Object.create(null);
   }
 
   get count() {
diff --git a/spec/integration/issues/issue-1339-speciel-cell-file.spec.js b/spec/integration/issues/issue-1339-speciel-cell-file.spec.js
@@ -0,0 +1,43 @@
+const ExcelJS = verquire('exceljs');
+
+// this file to contain integration tests created from github issues
+const TEST_XLSX_FILE_NAME = './spec/out/wb.test.xlsx';
+
+describe('github issues', () => {
+  it('issue 1339 - Special cell value results invalid file', async () => {
+    const wb = new ExcelJS.stream.xlsx.WorkbookWriter({
+      filename: TEST_XLSX_FILE_NAME,
+      useStyles: true,
+      useSharedStrings: true,
+    });
+    const ws = wb.addWorksheet('Sheet1');
+    const specialValues = [
+      'constructor',
+      'hasOwnProperty',
+      'isPrototypeOf',
+      'propertyIsEnumerable',
+      'toLocaleString',
+      'toString',
+      'valueOf',
+      '__defineGetter__',
+      '__defineSetter__',
+      '__lookupGetter__',
+      '__lookupSetter__',
+      '__proto__',
+    ];
+    for (let i = 0, len = specialValues.length; i < len; i++) {
+      const value = specialValues[i];
+      ws.addRow([value]);
+      ws.getCell(`B${i + 1}`).value = value;
+    }
+    await wb.commit();
+    const wb2 = new ExcelJS.Workbook();
+    await wb2.xlsx.readFile(TEST_XLSX_FILE_NAME);
+    const ws2 = wb2.getWorksheet('Sheet1');
+    for (let i = 0, len = specialValues.length; i < len; i++) {
+      const value = specialValues[i];
+      expect(ws2.getCell(`A${i + 1}`).value).to.equal(value);
+      expect(ws2.getCell(`B${i + 1}`).value).to.equal(value);
+    }
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ class SharedStrings {`
`2`	`2`	`constructor() {`
`3`	`3`	`this._values = [];`
`4`	`4`	`this._totalRefs = 0;`
`5`		`- this._hash = {};`
	`5`	`+ this._hash = Object.create(null);`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`get count() {`