fix tests

guyonroche · guyonroche · commit 9ec41e360d17 · 2019-10-30T08:42:39.000Z
diff --git a/lib/doc/cell.js b/lib/doc/cell.js
@@ -584,24 +584,31 @@ class HyperlinkValue {
       type: Cell.Types.Hyperlink,
       text: value ? value.text : undefined,
       hyperlink: value ? value.hyperlink : undefined,
-      tooltip: value.tooltip,
     };
+    if (value && value.tooltip) {
+      this.model.tooltip = value.tooltip;
+    }
   }
 
   get value() {
-    return {
+    const v = {
       text: this.model.text,
       hyperlink: this.model.hyperlink,
-      tooltip: this.model.tooltip,
     };
+    if (this.model.tooltip) {
+      v.tooltip = this.model.tooltip;
+    }
+    return v;
   }
 
   set value(value) {
     this.model = {
       text: value.text,
       hyperlink: value.hyperlink,
-      tooltip: value.tooltip,
     };
+    if (value.tooltip) {
+      this.model.tooltip = value.tooltip;
+    }
   }
 
   get text() {
diff --git a/spec/unit/xlsx/xform/test-xform-helper.js b/spec/unit/xlsx/xform/test-xform-helper.js
@@ -1,5 +1,5 @@
 const Sax = require('sax');
-const _ = require('../../../utils/under-dash');
+const {cloneDeep, each} = require('../../../utils/under-dash');
 
 const XmlStream = verquire('utils/xml-stream');
 const CompositeXform = verquire('xlsx/xform/composite-xform');
@@ -9,7 +9,7 @@ function getExpectation(expectation, name) {
   if (!expectation.hasOwnProperty(name)) {
     throw new Error(`Expectation missing required field: ${name}`);
   }
-  return _.cloneDeep(expectation[name]);
+  return cloneDeep(expectation[name]);
 }
 
 // ===============================================================================================================
@@ -28,7 +28,7 @@ const its = {
 
         const xform = expectation.create();
         xform.prepare(model, expectation.options);
-        expect(_.cloneDeep(model)).to.deep.equal(result);
+        expect(cloneDeep(model, false)).to.deep.equal(result);
         resolve();
       }));
   },
@@ -137,7 +137,7 @@ const its = {
             // console.log('expected Model', JSON.stringify(result));
 
             // eliminate the undefined
-            const clone = _.cloneDeep(model, false);
+            const clone = cloneDeep(model, false);
 
             // console.log('result', JSON.stringify(clone));
             // console.log('expect', JSON.stringify(result));
@@ -162,7 +162,7 @@ const its = {
           .parse(parser)
           .then(model => {
             // eliminate the undefined
-            const clone = _.cloneDeep(model, false);
+            const clone = cloneDeep(model, false);
 
             // console.log('result', JSON.stringify(clone));
             // console.log('expect', JSON.stringify(result));
@@ -185,7 +185,7 @@ const its = {
         xform.reconcile(model, expectation.options);
 
         // eliminate the undefined
-        const clone = _.cloneDeep(model, false);
+        const clone = cloneDeep(model, false);
 
         expect(clone).to.deep.equal(result);
         resolve();
@@ -194,10 +194,10 @@ const its = {
 };
 
 function testXform(expectations) {
-  _.each(expectations, expectation => {
+  each(expectations, expectation => {
     const tests = getExpectation(expectation, 'tests');
     describe(expectation.title, () => {
-      _.each(tests, test => {
+      each(tests, test => {
         its[test](expectation);
       });
     });
