Merge pull request #728 from LesterLyu/fix-worksheet-state

Siemienik · web-flow · commit 8fb94e9d8daa · 2019-02-18T23:42:40.000+01:00
Read worksheet hidden state
diff --git a/README.md b/README.md
@@ -238,7 +238,6 @@ var worksheet = workbook.getWorksheet(1);
 
 ```javascript
 // make worksheet visible
-worksheet.state = 'show';
 worksheet.state = 'visible';
 
 // make worksheet hidden
diff --git a/lib/doc/workbook.js b/lib/doc/workbook.js
@@ -193,10 +193,12 @@ Workbook.prototype = {
       var id = worksheetModel.id;
       var name = worksheetModel.name;
       var orderNo = value.sheets.findIndex(ws => ws.id === id);
+      var state = worksheetModel.state;
       var worksheet = this._worksheets[id] = new Worksheet({
         id: id,
         name: name,
         orderNo,
+        state,
         workbook: this
       });
 
diff --git a/spec/integration/data/test-pr-728.xlsx b/spec/integration/data/test-pr-728.xlsx
diff --git a/spec/integration/pr/test-pr-728.spec.js b/spec/integration/pr/test-pr-728.spec.js
@@ -0,0 +1,22 @@
+'use strict';
+
+var chai = require('chai');
+
+var verquire = require('../../utils/verquire');
+
+var Excel = verquire('excel');
+
+var expect = chai.expect;
+
+describe('github issues', function() {
+    it('pull request 728 - Read worksheet hidden state', function() {
+        var wb = new Excel.Workbook();
+        return wb.xlsx.readFile('./spec/integration/data/test-pr-728.xlsx')
+            .then(function() {
+                var expected = {1: 'visible', 2: 'hidden', 3: 'visible'};
+                wb.eachSheet(function(ws, sheetId) {
+                    expect(ws.state).to.equal(expected[sheetId]);
+                });
+            });
+    });
+});
