Merge pull request #232 from pookong/do_not_skip_empty_shared_string

guyonroche · web-flow · commit 202593aef1c3 · 2016-12-02T18:14:10.000Z
do not skip empty string in shared strings so that indexes match
diff --git a/lib/xlsx/xform/strings/shared-string-xform.js b/lib/xlsx/xform/strings/shared-string-xform.js
@@ -60,7 +60,7 @@ utils.inherits(SharedStringXform, BaseXform, {
       model.richText.forEach(function(text) {
         r.render(xmlStream, text);
       });
-    } else if (model) {
+    } else if (model !== undefined && model !== null) {
       this.map.t.render(xmlStream, model);
     }
     xmlStream.closeNode();

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ utils.inherits(SharedStringXform, BaseXform, {`
`60`	`60`	`model.richText.forEach(function(text) {`
`61`	`61`	`r.render(xmlStream, text);`
`62`	`62`	`});`
`63`		`- } else if (model) {`
	`63`	`+ } else if (model !== undefined && model !== null) {`
`64`	`64`	`this.map.t.render(xmlStream, model);`
`65`	`65`	`}`
`66`	`66`	`xmlStream.closeNode();`