Bug fix for issue 128, plus useful extensions #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See problem identified in github Issue 128. This patch has been submitted as Issue 137
Thor classes). Add Thor.banner method to set overall banner for a Thor class. Add tests for Thor.banner
…ts match no method, i.e. thor klass blah # where blah is not a task, defaults to: thor klass default_task blah Also add tests for default tasks with arguments, and fix typo in documentation comments for default_task
Contributor
|
This looks good to me. Any other comments before we merge? |
Contributor
|
Has this been tested with any of the important uses of thor, like rails or bundler? |
Member
|
Additionally, can you rebase. I pulled a different fix for 128 before I saw this. |
This was referenced May 7, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces pull request at issue 143. It includes a bug fix for issue 128 and some changes to add a few capabilities I've found helpful:
This fixes the bugs in the original submission of this patch It passes all tests ONCE YOU FIX THE BUG identified in issue 144. See my patch submitted separately as issue 146.
Thanks again to everyone else whose work made Thor so terrific.