You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see, in the dev version, that the genre table has changed, and that the pixar_films table no longer has a missing value. The dm package makes certain assumptions about the structure of the data, and so might other users. Curious to hear your thoughts on how to deal with that.
Releasing dm 1.0.11 now, but I can push an update on short notice if needed.
The text was updated successfully, but these errors were encountered:
@krlmlr thanks for the issue. I did notice this too for the dm package as I was doing some testing.
The breaking change for the genres table is to expand the table a bit. I don't expect to change it that often. But I'm finally doing an update of the data, so I found some extra subgenres that I wanted, hence the breaking change.
Happy to make the updates to dm package function. The schema for the genres data is now three columns: film, category, value.
Regarding pixar_films no longer having missing data, that was a feature of at the time, Pixar didn't realize the title of the film. But now, the table I'm pulling from has all the films named. And I don't include any unreleased films anymore. So, for this issue, I'm not sure you want to work around this.
I see, in the dev version, that the
genre
table has changed, and that thepixar_films
table no longer has a missing value. The dm package makes certain assumptions about the structure of the data, and so might other users. Curious to hear your thoughts on how to deal with that.Releasing dm 1.0.11 now, but I can push an update on short notice if needed.
The text was updated successfully, but these errors were encountered: