Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection_pool_per_downstream_connection - close upstream connection when downstream closes #37617

Open
Pawan-Bishnoi opened this issue Dec 11, 2024 · 2 comments
Open

connection_pool_per_downstream_connection - close upstream connection when downstream closes #37617

Pawan-Bishnoi opened this issue Dec 11, 2024 · 2 comments
Labels
enhancement Feature requests. Not bugs or questions. triage Issue requires triage

Comments

@Pawan-Bishnoi
Copy link
Contributor

Title: Close upstream connection soon after downstream connection is closed.

Description:
Enabling connection_pool_per_downstream_connection increases the number of open connections on the server app side (which is expected).
What is worrisome though is that these connections remain open for much longer than needed and are closed by idleTimeout (which takes atleast 8 minutes? Even if tcp keepalive time it set really small)

In case of connection_pool_per_downstream_connection, we don't have to wait for idleTimeout once the downstream is disconnected since the mapping is 1:1.
@Pawan-Bishnoi Pawan-Bishnoi added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 11, 2024
@Pawan-Bishnoi
Copy link
Contributor Author

Original issue: #12370 where this feature was added.

@Pawan-Bishnoi
Copy link
Contributor Author

I read somewhere (unable to find the doc now) that the 8 minute number is coming from this calculation:

  1. keepalive_probes - 7 is the default value
  2. keepalive_interval - 75 seconds
  3. keepalive_time - tried setting it to 1 second. This is the only configurable value?

keepalive_time + keepalive_probes * keepalive_interval = 526 seconds → 8.77 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions. triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pawan-Bishnoi