Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per descriptor hits_addend support #37347

Open
wbpcode opened this issue Nov 25, 2024 · 1 comment · May be fixed by #37361
Open

per descriptor hits_addend support #37347

wbpcode opened this issue Nov 25, 2024 · 1 comment · May be fixed by #37361
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@wbpcode
Copy link
Member

wbpcode commented Nov 25, 2024

Title: per descriptor hits_addend support

Description:

No, although we can provide multiple descritpor in same rate limit request, but they all share same hits_addend. Then if we want to limit the qps and bandwidth at same time, we need to configure two rate limit filters at the same filter chain. It's a little complex and add addtional overhead/latency.

@wbpcode wbpcode added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 25, 2024
@agrawroh agrawroh linked a pull request Nov 26, 2024 that will close this issue
@wbpcode wbpcode removed the triage Issue requires triage label Nov 26, 2024
@wbpcode
Copy link
Member Author

wbpcode commented Nov 26, 2024

cc @mattklein123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant