Description
Title: Use type URL for cluster factories
Description:
from #36353. We want to use type URL instead of names for cluster factories. That is refactor the following code
envoy/source/common/upstream/cluster_factory_impl.cc
Lines 18 to 66 in f918986
This is somewhat complex some cluster types (original dst, static), don't have type URLs, so we're probably going to need to create placeholder protos for them.
There is also a question for how much backcompatibility we want to preserve. For example, the following cluster is valid,
cluster_type:
name: envoy.cluster.original_dst # or static
typed_config:
"@type": type.googleapis.com/envoy.extensions.network.dns.v3.GetAddrInfo # or anything else, but not empty
This means that if we want to be strict about backcompatibility, we will never be able to select cluster factories purely by type_url. However, I'd be pretty surprised if anybody is using a config like the one above, since it doesn't make a lot of sense.
[optional Relevant Links:]
Any extra documentation required to understand the issue.
Activity