Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed_dns_resolver_config to Redis cluster proto #37142

Open
Stevenjin8 opened this issue Nov 14, 2024 · 1 comment
Open

Add typed_dns_resolver_config to Redis cluster proto #37142

Stevenjin8 opened this issue Nov 14, 2024 · 1 comment
Labels
api area/cluster enhancement Feature requests. Not bugs or questions.

Comments

@Stevenjin8
Copy link
Contributor

Title: One line description

Description:

An outcome of #36353 is to deprecate dns-related fields from envoy.config.clusters.v3.Cluster and move them to extension points.
One troubling field is typed_dns_resolver_config because it is also used by the Redis cluster. As such, typed_dns_resolver_config is in a half deprecated state: it is deprecated for {logical,strict} dns clusters, but not for Redis clusters. We should add a typed_dns_resolver_config field to the redis extension point to fully deprecate envoy.config.cluster.v3.Cluster.typed_dns_resolver_config.

Also, some deal for dns_lookup_family.

[optional Relevant Links:]

https://github.com/envoyproxy/envoy/pull/36353/files

@Stevenjin8 Stevenjin8 added the triage Issue requires triage label Nov 14, 2024
@Stevenjin8
Copy link
Contributor Author

/staleproof

@yanavlasov yanavlasov added enhancement Feature requests. Not bugs or questions. api area/cluster and removed triage Issue requires triage labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area/cluster enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

2 participants