-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undeprecate max_grpc_timeout #37134
Comments
Honestly I don't know why we warn on deprecated config at all given plans to never rev versions again |
RE un-deprecation - I'm not sure that it is the right thing to do (but we'll need to look at the details before suggesting a path forward). RE logging - as deprecated fields will probably be supported indefinitely, it may make sense to reduce the logging frequency to once or every N seconds. |
#12578 has the context for the old timeout field. tl;dr it's different from how gRPC internally behaves because it only starts when the client closes its sending side of the stream. |
How about introducing a new runtime flag that controls whether deprecated features should be logged or not? |
I'd suggest adding a bootstrap knob that controls that (because runtime flags are intended to be temporary, and bootstrap knobs are more permanent). |
Fair point. We will change it like that |
Could you please review this #37407, which provides an option to suppress deprecated warning logs using a command-line option, and provide your feedback. |
Given that there are issues with the replaced fields
grpc_timeout_header_max
as explained here and there is no consensus on what is the way forward - I am proposing to un-deprecate this field. We can deprecate it again if and when sort the above issues.With being deprecated, in a large system with many routes our logs are filled with deprecated warnings
cc: @alyssawilk
The text was updated successfully, but these errors were encountered: