Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undeprecate max_grpc_timeout #37134

Open
ramaraochavali opened this issue Nov 14, 2024 · 8 comments
Open

undeprecate max_grpc_timeout #37134

ramaraochavali opened this issue Nov 14, 2024 · 8 comments
Labels
area/grpc enhancement Feature requests. Not bugs or questions.

Comments

@ramaraochavali
Copy link
Contributor

Given that there are issues with the replaced fields grpc_timeout_header_max as explained here and there is no consensus on what is the way forward - I am proposing to un-deprecate this field. We can deprecate it again if and when sort the above issues.

With being deprecated, in a large system with many routes our logs are filled with deprecated warnings

cc: @alyssawilk

@ramaraochavali ramaraochavali added the triage Issue requires triage label Nov 14, 2024
@yanavlasov yanavlasov added enhancement Feature requests. Not bugs or questions. area/grpc and removed triage Issue requires triage labels Nov 14, 2024
@alyssawilk
Copy link
Contributor

Honestly I don't know why we warn on deprecated config at all given plans to never rev versions again
cc @adisuissa @envoyproxy/api-shepherds
If it's causing problems I'd send out a PR and see if folks object.

@markdroth
Copy link
Contributor

I don't think we want to un-deprecate max_grpc_timeout, since my recollection is that it's basically broken from the perspective of gRPC timeout semantics. @dfawley or @ejona86 may remember the details here.

@adisuissa
Copy link
Contributor

RE un-deprecation - I'm not sure that it is the right thing to do (but we'll need to look at the details before suggesting a path forward).

RE logging - as deprecated fields will probably be supported indefinitely, it may make sense to reduce the logging frequency to once or every N seconds.

@dfawley
Copy link
Member

dfawley commented Nov 14, 2024

#12578 has the context for the old timeout field. tl;dr it's different from how gRPC internally behaves because it only starts when the client closes its sending side of the stream.

@ramaraochavali
Copy link
Contributor Author

How about introducing a new runtime flag that controls whether deprecated features should be logged or not?

@adisuissa
Copy link
Contributor

How about introducing a new runtime flag that controls whether deprecated features should be logged or not?

I'd suggest adding a bootstrap knob that controls that (because runtime flags are intended to be temporary, and bootstrap knobs are more permanent).

@ramaraochavali
Copy link
Contributor Author

Fair point. We will change it like that

@vamshi177
Copy link
Contributor

Could you please review this #37407, which provides an option to suppress deprecated warning logs using a command-line option, and provide your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

7 participants