Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lua API for accessing dynamic metadata #3618

Closed
dio opened this issue Jun 13, 2018 · 3 comments
Closed

Add Lua API for accessing dynamic metadata #3618

dio opened this issue Jun 13, 2018 · 3 comments
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@dio
Copy link
Member

dio commented Jun 13, 2018 •
edited
Loading

Description:

Add Lua API for accessing dynamic metadata as discussed in: #2436 (comment)

The API could be done as follows:

function envoy_on_request(request_handle)
  request_handle:requestInfo():dynamicMetadata():set("envoy.lb", "foo", "bar")
  request_handle:requestInfo():dynamicMetadata():get("envoy.lb")["foo"]
end

However this is still a rough design. This needs more input.

@moss94 @sahanaha
@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Jun 13, 2018
@dio dio mentioned this issue Jun 14, 2018
Closed
@dio dio mentioned this issue Jul 6, 2018
Merged
@stale
Copy link

stale bot commented Jul 13, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 13, 2018
@stale
Copy link

stale bot commented Jul 20, 2018

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Jul 20, 2018
@dio
Copy link
Member Author

dio commented Jul 20, 2018

Oops, #3800 is still in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dio @mattklein123