Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filters to set metadata matches from request #3255

Closed
rgs1 opened this issue Apr 30, 2018 · 3 comments
Closed

Allow filters to set metadata matches from request #3255

rgs1 opened this issue Apr 30, 2018 · 3 comments
Labels
question Questions that are neither investigations, bugs, nor enhancements

Comments

@rgs1
Copy link
Member

rgs1 commented Apr 30, 2018

This is related to #2436, but geared towards exposing the right APIs for filter writers to do what #2436 wants to expose via config language.

I am playing with #3254 to prototype how this would look.

To reiterate, the main use case I can think of (and which I am currently trying to solve) is being able to set metadata matches from a header (e.g.: X-Version) instead of having to hard-code route entries with each possible version, e.g.:

---
match:
  prefix: /
route:
  cluster: cluster-name
  metadata_match:
    filter_metadata:
      envoy.lb:
        version: '1.0'

(Assume using RDS to construct all the possible route combinations dynamically isn't a desired path).

Thoughts on how this should be approached?

@mattklein123 mattklein123 added the question Questions that are neither investigations, bugs, nor enhancements label Apr 30, 2018
@mattklein123
Copy link
Member

@zuercher do you mind taking this question?

@stale
Copy link

stale bot commented Jun 19, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 19, 2018
@mattklein123 mattklein123 added stale stalebot believes this issue/PR has not been touched recently and removed wontfix labels Jun 19, 2018
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 19, 2018
@mattklein123
Copy link
Member

I think this is fixed with the new filter! Thanks @rgs1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions that are neither investigations, bugs, nor enhancements
Projects
None yet
Development

No branches or pull requests

2 participants