Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use os.EOL instead of \n #242

Closed
Guria opened this issue Jun 22, 2015 · 2 comments · Fixed by #243
Closed

use os.EOL instead of \n #242

Guria opened this issue Jun 22, 2015 · 2 comments · Fixed by #243
Milestone
0.16

Comments

@Guria
Copy link
Contributor

Guria commented Jun 22, 2015

@blond I'll prepare a PR, but I need your advice.
Should we just replace \n with EOL or we have to introduce optional parameter for join string with \n as default for better reverse compatibility?
@blond
Copy link
Member

blond commented Jun 22, 2015

Just replace \n with EOL.

@Guria Guria mentioned this issue Jun 22, 2015
Merged
@blond blond added the review label Jun 22, 2015
@Guria
Copy link
Contributor Author

Guria commented Jun 24, 2015

I see PR with tests. I'll rebase and replace \n to EOL in it

@blond blond removed the review label Jun 24, 2015
@blond blond added this to the 0.16 milestone Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

use os.EOL instead of \n
2 participants
@Guria @blond