feat(serial): allow Bluetooth ports to be requested by service class ID #41638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/minor
electron-cation
bot
added
api-review/requested 🗳
new-pr 🌱
jkleinsc
requested changes
Mar 21, 2024
There was a problem hiding this comment.
Looks like the GN checks are failing, eg:
https://app.circleci.com/pipelines/github/electron/electron/79480/workflows/73955dd2-f239-4a89-b9e7-527b90a9ac22/jobs/1689290
codebytere
force-pushed
the
allow-port-request-bluetooth
branch
from
446bb97
to
60d1de8
Compare
|
@jkleinsc fixed! |
jkleinsc
approved these changes
Mar 22, 2024
deepak1556
approved these changes
Mar 22, 2024
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
Release Notes Persisted
|
This was referenced Mar 28, 2024
|
I have automatically backported this PR to "30-x-y", please check out #41734 |
trop
bot
added
in-flight/30-x-y
and removed
target/30-x-y
|
I have automatically backported this PR to "29-x-y", please check out #41735 |
trop
bot
added
in-flight/29-x-y
merged/30-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs CL:4522192.
In #38465 we added a parameter to
ElectronSerialDelegate::RunChooserto account for upstream changes but never actually implemented the feature the parameter was added to support. This PR adds support for Bluetooth ports being requested by service class ID, thereby bringing our WebSerial implementation into alignment with the current state of the web platform api. Now, users can do e.g:Checklist
npm testpassesRelease Notes
Notes: Added support for Bluetooth ports being requested by service class ID in
navigator.serial.