Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate compiler warnings #127

Open
momohatt opened this issue Nov 23, 2019 · 4 comments
Open

Eliminate compiler warnings #127

momohatt opened this issue Nov 23, 2019 · 4 comments
Labels
contribution welcome refactor

Comments

@momohatt
Copy link
Member

Currently, building Egison code with -Wall flag issues a lot of warnings. We should deal with these warnings for improving code sanity.

cf. https://downloads.haskell.org/~ghc/latest/docs/html/users_guide/using-warnings.html
@momohatt
Copy link
Member Author

momohatt commented Nov 28, 2019 •
edited
Loading

  • Eliminate -Wno-incomplete-patterns
  • Eliminate -Wno-unused-matches
  • (Optional) Eliminate warnings from Parser.hs, which is suppressed for now

I'm not sure if we should also try to eliminate -Wno-name-shadowing.

@momohatt momohatt changed the title Eliminate GHC warning Eliminate compiler warnings Oct 3, 2020
@xzfc xzfc mentioned this issue Oct 17, 2020
Merged
@stmtk1
Copy link

stmtk1 commented Jan 25, 2022

there are only a few warnings, "-Wunused-matches" and "-Wunused-local-binds". I think these warnings are not critical. If these should be eliminate, I want to do.

@momohatt
Copy link
Member Author

momohatt commented Jan 26, 2022 •
edited
Loading

Sure, thanks. But you'll have to fix sweet-egison (not egison itself) to remove the -Wunused-local-binds warnings in Math/Rewrite.hs. You can ignore them if you want to.

@stmtk1
Copy link

stmtk1 commented Jan 28, 2022

I aware removing -Wunused-local-binds is very difficult. So I will try eliminating another warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stmtk1 @momohatt