Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dispose virtual #137

Merged
merged 18 commits into from
May 20, 2020
Merged

make dispose virtual #137

merged 18 commits into from
May 20, 2020

Conversation

SimonCropp
Copy link
Contributor

since i need to override it in verify.bunit

@egil egil changed the base branch from master to dev May 20, 2020 10:49
@egil egil merged commit 6d2adcc into bUnit-dev:dev May 20, 2020
@egil
Copy link
Member

egil commented May 20, 2020

Thanks for this. Good catch.

I have merged the PR into DEV. There should be a new nuget package in the GitHub Package Repository with this change in it soon, that you can pull and build on.

@SimonCropp
Copy link
Contributor Author

awesome. thanks. btw has the doco been updated to reflect the new beta?

@egil
Copy link
Member

egil commented May 20, 2020

@SimonCropp its a work in progress... The most basic parts have. I do plan to write a bunch of short "how to" articles that will cover a topic each.

Here is the packages btw.: https://github.com/egil/bunit/packages
You need to set up a personal github token to be able to download from the package registry.

@SimonCropp
Copy link
Contributor Author

thanks. but as an extension to bunit that is deployed via nunit, i can consume it until bunit is on nuget

@SimonCropp SimonCropp deleted the MakeDisposeVirtual branch May 20, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants