Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/300 jsinterop exception messages #346

Merged
merged 6 commits into from
Mar 25, 2021
Merged

Feature/300 jsinterop exception messages #346

merged 6 commits into from
Mar 25, 2021

Conversation

egil
Copy link
Member

@egil egil commented Mar 24, 2021 •
edited
Loading

Pull request description

Fixes #300.

PR meta checklist

  • Pull request is targeted at DEV branch for code
    or targeted at main branch for documentation that is live on bunit.egilhansen.com.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@egil egil self-assigned this Mar 24, 2021
@egil egil linked an issue Mar 24, 2021 that may be closed by this pull request
Improve error messages from JSRuntimeUnhandledInvocationException #300
Closed
@codecov
Copy link

codecov bot commented Mar 24, 2021 •
edited
Loading

Codecov Report

Merging #346 (3e53e65) into dev (229912f) will increase coverage by 0.62%.
The diff coverage is 97.97%.

❗ Current head 3e53e65 differs from pull request most recent head 919944c. Consider uploading reports for the commit 919944c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #346      +/-   ##
==========================================
+ Coverage   81.65%   82.28%   +0.62%     
==========================================
  Files         125      126       +1     
  Lines        3837     3973     +136     
  Branches      495      501       +6     
==========================================
+ Hits         3133     3269     +136     
+ Misses        542      541       -1     
- Partials      162      163       +1
Impacted Files Coverage Δ
src/bunit.web/JSInterop/BunitJSModuleInterop.cs 100.00% <ø> (ø)
...nit.web/JSInterop/JSRuntimeInvocationDictionary.cs 85.71% <ø> (ø)
...JSInterop/JSRuntimeUnhandledInvocationException.cs 94.59% <94.02%> (+16.02%) ⬆️
src/bunit.web/JSInterop/BunitJSInterop.cs 96.42% <100.00%> (+1.55%) ⬆️
...nit.web/JSInterop/BunitJSInteropSetupExtensions.cs 81.81% <100.00%> (+4.04%) ⬆️
...eb/JSInterop/BunitJSInteropSetupExtensions.net5.cs 88.23% <100.00%> (+0.73%) ⬆️
...JSInterop/Implementation/BunitJSObjectReference.cs 78.57% <100.00%> (+7.14%) ⬆️
...nit.web/JSInterop/Implementation/BunitJSRuntime.cs 100.00% <100.00%> (ø)
...eb/JSInterop/Implementation/BunitJSRuntime.net5.cs 100.00% <100.00%> (ø)
...eb/JSInterop/Implementation/JSRuntimeExtensions.cs 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229912f...919944c. Read the comment docs.

@egil egil merged commit 3e7f068 into dev Mar 25, 2021
@egil egil deleted the feature/300-jsinterop-exception-messages branch March 25, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@egil egil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error messages from JSRuntimeUnhandledInvocationException
1 participant
@egil