Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple fake navigation manager #345

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Simple fake navigation manager #345

merged 5 commits into from
Mar 23, 2021

Conversation

egil
Copy link
Member

@egil egil commented Mar 22, 2021 •
edited
Loading

Pull request description

Closes #117.

PR meta checklist

  • Pull request is targeted at DEV branch for code
    or targeted at main branch for documentation that is live on bunit.egilhansen.com.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@egil egil self-assigned this Mar 22, 2021
@egil egil changed the base branch from main to dev March 22, 2021 15:55
@codecov
Copy link

codecov bot commented Mar 22, 2021 •
edited
Loading

Codecov Report

Merging #345 (0150d4f) into dev (143350b) will decrease coverage by 0.68%.
The diff coverage is 90.90%.

❗ Current head 0150d4f differs from pull request most recent head 6de5e09. Consider uploading reports for the commit 6de5e09 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #345      +/-   ##
==========================================
- Coverage   81.60%   80.92%   -0.69%     
==========================================
  Files         126      115      -11     
  Lines        3839     3691     -148     
  Branches      495      484      -11     
==========================================
- Hits         3133     2987     -146     
+ Misses        545      540       -5     
- Partials      161      164       +3
Impacted Files Coverage Δ
...Doubles/NavigationManager/FakeNavigationManager.cs 90.00% <90.00%> (ø)
...it.web/Extensions/TestServiceProviderExtensions.cs 71.42% <100.00%> (ø)
src/bunit.web/Diffing/BlazorDiffingHelpers.cs 42.85% <0.00%> (-28.58%) ⬇️
...nit.web/JSInterop/BunitJSInteropSetupExtensions.cs 71.42% <0.00%> (-6.35%) ⬇️
...c/bunit.web/Asserting/JSRuntimeAssertExtensions.cs 80.43% <0.00%> (-4.35%) ⬇️
src/bunit.web/Rendering/Internal/Htmlizer.cs 81.92% <0.00%> (-2.26%) ⬇️
src/bunit.web/JSInterop/BunitJSInterop.cs 93.93% <0.00%> (-0.94%) ⬇️
src/bunit.core/TestServiceProvider.cs 94.28% <0.00%> (-0.09%) ⬇️
src/bunit.web/Rendering/WebTestRenderer.cs 100.00% <0.00%> (ø)
...ion/LooseModeJSObjectReferenceInvocationHandler.cs
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143350b...6de5e09. Read the comment docs.

@egil
Copy link
Member Author

egil commented Mar 22, 2021

Docs will be updated via a separate pull request.

@egil egil merged commit 3afb39a into dev Mar 23, 2021
@egil egil deleted the feature/117-fake-navman branch March 23, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@egil egil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fake NavigationManager
1 participant
@egil